build: vendor libtermkey #25870
Merged
build: vendor libtermkey #25870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
dundargoc
force-pushed
the
build/libtermkey
branch
11 times, most recently
from
e1a8e46 to
432b69c
Compare
|
This is pretty much good to go, but I don't wanna pollute PRs with something that may not be useful at the moment. We can resurrect this when required later. |
|
I'm re-opening this because vendoring libtermkey before a 0.10 release is a very real possibility. There are two patches to libtermkey that we need: neovim/libtermkey#5 If a new libtermkey release is created that packagers can use then we do not need to vendor termkey, but since libtermkey is marked deprecated upstream it seems unlikely that a new release will be made. |
gpanders
force-pushed
the
build/libtermkey
branch
from
432b69c to
7b46b2b
Compare
|
Rebased on master and applied both of our patches. |
This is a proof of concept/WIP to evaluate the viability of vendoring libtermkey as it's been deprecated.
gpanders
force-pushed
the
build/libtermkey
branch
from
8045e2f to
5999214
Compare
gpanders
force-pushed
the
build/libtermkey
branch
from
7fbf9f0 to
50f5864
Compare
|
If we decide to move forward:
|
gpanders
added
the
needs:discussion
|
I'm going to move forward with this now as this will resolve issues like #26038 immediately for all users using Neovim HEAD, not just those using the bundled deps. If the situation changes before a 0.10 release (meaning, a new version of termkey is released, or its functionality is integrated into libtickit), we can revert this. |
gpanders
removed
the
needs:discussion
6 tasks
carlocab
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 27, 2024
This is no longer used in HEAD, and will not be used in 0.10. See neovim/neovim#25870.
13 tasks
gpanders
added a commit
to gpanders/neovim
that referenced
this pull request
Aug 5, 2024
It's been vendored since neovim#25870.
clason
pushed a commit
that referenced
this pull request
Aug 5, 2024
It's been vendored since #25870.
casr
added a commit
to casr/macports-ports
that referenced
this pull request
Oct 3, 2024
`neovim`: - removed `lua51-mpack` as a dependency since it's [no longer required][0] - removed `libtermkey` as a dependency since it's [no longer required][1] [0]: neovim/neovim#15566 [1]: neovim/neovim#25870 `neovim-devel`: - removed `msgpack` as a dependency since it's [no longer required][2] - removed `libvterm` as a dependency since it's [no longer required][3] [2]: neovim/neovim#29540 [3]: neovim/neovim#30011 Also note that `neovim-devel` is not progressing passed 2024-08-31 until `utf8proc` sees its next release. Versions after this date will fail with a compile error due to a type mismatch. Fixes: https://trac.macports.org/ticket/70028
9 tasks
casr
added a commit
to casr/macports-ports
that referenced
this pull request
Oct 3, 2024
`neovim`: - removed `lua51-mpack` as a dependency since it's [no longer required][0] - removed `libtermkey` as a dependency since it's [no longer required][1] [0]: neovim/neovim#15566 [1]: neovim/neovim#25870 `neovim-devel`: - removed `msgpack` as a dependency since it's [no longer required][2] - removed `libvterm` as a dependency since it's [no longer required][3] [2]: neovim/neovim#29540 [3]: neovim/neovim#30011 Also note that `neovim-devel` is not progressing past 2024-08-31 until `utf8proc` sees its next release. Versions after this date will fail with a compile error due to a type mismatch. Fixes: https://trac.macports.org/ticket/70028
l2dy
pushed a commit
to macports/macports-ports
that referenced
this pull request
Oct 11, 2024
`neovim`: - removed `lua51-mpack` as a dependency since it's [no longer required][0] - removed `libtermkey` as a dependency since it's [no longer required][1] [0]: neovim/neovim#15566 [1]: neovim/neovim#25870 `neovim-devel`: - removed `msgpack` as a dependency since it's [no longer required][2] - removed `libvterm` as a dependency since it's [no longer required][3] [2]: neovim/neovim#29540 [3]: neovim/neovim#30011 Also note that `neovim-devel` is not progressing past 2024-08-31 until `utf8proc` sees its next release. Versions after this date will fail with a compile error due to a type mismatch. Fixes: https://trac.macports.org/ticket/70028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept/WIP to evaluate the viability of vendoring
libtermkey as it's been deprecated.