FEATURE: Ckeditor inline element support #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin the "Configuration Helper" was used for the placeholder implementation; but we re-implement it ourselves now.
|
Just a thought: maybe at some point we should host our own version of CKE on npm, since they are too lazy to do that. Putting its source into our repo feels nasty. Will review the rest now. |
dimaip
approved these changes
Sep 13, 2017
- Make copy/paste to spans working (strips formatting) - re-implement placeholders to work with inline elements as well Resolves: #834
skurfuerst
force-pushed
the
ckeditor-inline-element-support
branch
from
440311e to
7cd0639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #834