Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editables with span tagName behaves strangely when pasting content #834

Closed
dimaip opened this issue Aug 24, 2017 · 4 comments
Closed

Editables with span tagName behaves strangely when pasting content #834

dimaip opened this issue Aug 24, 2017 · 4 comments
Assignees
@skurfuerst
Labels
Bug Label to mark the change as bugfix CKEditor
Milestone
1.0.0 must haves

Comments

@dimaip
Copy link
Contributor

dimaip commented Aug 24, 2017 •
edited by skurfuerst
Loading

<- must-have for 1.0.0

When pasting content inside span editable it doesn't get saved:

peek 2017-08-24 15-42
@dimaip dimaip added the Bug Label to mark the change as bugfix label Aug 24, 2017
@dimaip dimaip added this to the 1.0.0 must haves milestone Sep 1, 2017
@skurfuerst skurfuerst mentioned this issue Sep 4, 2017
Closed
58 tasks
@dimaip
Copy link
Contributor Author

dimaip commented Sep 6, 2017

@grebaldi this would be the area probably that you know best, right?

@dimaip
Copy link
Contributor Author

dimaip commented Sep 6, 2017

Actually such editables are completely unusable. Remove all content from it, and then the editable is gone. Unfocus it and you'd see the placeholder. Focus it again and it's gone again.

peek 2017-09-06 17-02

@skurfuerst skurfuerst self-assigned this Sep 8, 2017
@skurfuerst
Copy link
Member

OK, have found a way to fix the placeholder handling. Copy/Paste coming :)

will all push tomorrow

@dimaip
Copy link
Contributor Author

dimaip commented Sep 12, 2017

You are a CKE magician! ;)
Also I noticed that CKE converts «french quotes» and other Unicode characters into html entities, which causes them to render as &laquo;french quotes&raquo;, if you don't use f:format.raw() in Fluid.

skurfuerst added a commit that referenced this issue Sep 13, 2017
@skurfuerst
FEATURE: Implement better support for non-block editables like spans
440311e 
- Make copy/paste to spans working (strips formatting)
- re-implement placeholders to work with inline elements as well

Resolves: #834
@skurfuerst skurfuerst mentioned this issue Sep 13, 2017
Merged
@dimaip dimaip mentioned this issue Sep 13, 2017
Merged
skurfuerst added a commit that referenced this issue Sep 14, 2017
@skurfuerst
FEATURE: Implement better support for non-block editables like spans
7cd0639 
- Make copy/paste to spans working (strips formatting)
- re-implement placeholders to work with inline elements as well

Resolves: #834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skurfuerst skurfuerst

Labels
Bug Label to mark the change as bugfix CKEditor
Projects
None yet
Milestone
1.0.0 must haves
Development

No branches or pull requests
2 participants
@skurfuerst @dimaip