Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: only allow to create nodes of the same role as the reference node #906

Merged
merged 2 commits into from
Sep 8, 2017
Merged

BUGFIX: only allow to create nodes of the same role as the reference node #906

merged 2 commits into from
Sep 8, 2017

Conversation

dimaip
Copy link
Contributor

@dimaip dimaip commented Sep 7, 2017

Fixes: #766

@dimaip dimaip added the Bug Label to mark the change as bugfix label Sep 7, 2017
@dimaip dimaip requested a review from skurfuerst September 7, 2017 11:40
dfeyer
dfeyer suggested changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@dfeyer dfeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not respect node contraints when adding node in a ContentCollection

@skurfuerst
Copy link
Member

Hm, need to investigate wyh this is the case; actually this has worked before I am quite sure

@dimaip
Copy link
Contributor Author

dimaip commented Sep 8, 2017

Hmm again I can not reproduce, sorry! Can you post an example NodeTypes.yaml snippet and exact description how to reproduce it.
I checked it with Sfi.Grid extension: https://github.com/psmb/Sfi.Grid/blob/master/Configuration/NodeTypes.yaml

image

@dfeyer
Copy link
Contributor

dfeyer commented Sep 8, 2017

I can do more test later today

@dimaip
Copy link
Contributor Author

dimaip commented Sep 8, 2017

@dfeyer Can you also test if it was my changed that broke it for you or not. Because if not we can just merge this one.

@skurfuerst skurfuerst merged commit 3c79301 into neos:master Sep 8, 2017
@dimaip dimaip deleted the roles branch September 8, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfeyer dfeyer dfeyer requested changes

@skurfuerst skurfuerst skurfuerst approved these changes

Assignees
No one assigned
Labels
Bug Label to mark the change as bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimaip @skurfuerst @dfeyer