Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages can be added after main content collection #766

Closed
daniellienert opened this issue Jul 11, 2017 · 5 comments
Closed

Pages can be added after main content collection #766

daniellienert opened this issue Jul 11, 2017 · 5 comments

Comments

@daniellienert
Copy link
Member

daniellienert commented Jul 11, 2017

<- must-have for 1.0.0

When selecting the main content collection in the content tree, press plus and select "insert after" the list of document nodes is shown.

This is technically correct but a bit confusing for editors. I would propose to disable the "insert after" mode there.

@skurfuerst
Copy link
Member

Hey,

I think forbidding this completely might not be the right approach; as there might be cases where Document Nodes will be directly editable on the page -> then it would feel natural to be able to insert them directly in-place in the content area.

I could imagine the following: We make it configurable on a per-node-type basis whether it is shown in the "Add Content" dialog or not. For Content, we enable it by default; for Document, we disable it by default.

What do you think?

All the best, Sebastian

@daniellienert
Copy link
Member Author

Hey Sebastian,
that would be a good default behavior!

Cheers,
Daniel

@skurfuerst
Copy link
Member

Hey,

marking this as "Must have for 1.0" as it is a major usability issue for editors.

All the best, Sebastian

@dimaip
Copy link
Contributor

dimaip commented Sep 6, 2017

Hey guys!
I don't think I'm in favor of adding another configuration option before 1.0.
I propose this behavior: when a document node is selectable inline, when you click an inline button, you'd get a dialog with only document nodes there, same as you would get from the document tree toolbar.
When you click add node button from content tree toolbar, you'd get just content nodes, consistent with the old UI.
Wdyt?

@skurfuerst
Copy link
Member

Good idea <3 Let's do it your way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants