Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Full select editor (with data providers and multiselect support) #764

Merged
merged 6 commits into from
Sep 6, 2017
Merged

FEATURE: Full select editor (with data providers and multiselect support) #764

merged 6 commits into from
Sep 6, 2017

Conversation

skurfuerst
Copy link
Member

@skurfuerst skurfuerst commented Jul 8, 2017 •
edited
Loading

  • Implement Data Sources for Select Editor
  • Implement Data Sources for MultiSelect Editor
  • implement search field for Select Editor without data source
  • implement search field for Select Editor with data source
  • implement search field for MultiSelect Editor without data source
  • implement search field for MultiSelect Editor with data source
  • add tests
  • implement allowEmpty in SelectEditor
  • implement allowEmpty in MultiSelectEditor
  • add ticket for implementing Group Support in SelectBox/MultiSelectBox

@skurfuerst skurfuerst self-assigned this Jul 8, 2017
@skurfuerst skurfuerst force-pushed the full-select-editor branch from 8937f91 to de129ba Compare July 9, 2017 07:51
@mstruebing mstruebing mentioned this pull request Jul 31, 2017
Closed
@dimaip
Copy link
Contributor

dimaip commented Aug 2, 2017

What is this PR?

@skurfuerst
Copy link
Member Author

This PR is my WIP attempt of implementing DataProviders etc. Will continue on this now :)

@skurfuerst skurfuerst mentioned this pull request Sep 4, 2017
Closed
58 tasks
@skurfuerst skurfuerst force-pushed the full-select-editor branch 2 times, most recently from 94c5988 to 4793cbd Compare September 6, 2017 08:31
@skurfuerst
FEATURE: Implement Data Providers and MultiSelect in Select Editor
9d4eadc 
In Select Editor, we now support Data Providers and local values. Both
cases work with single- and multiselect.

Besides, the rendering of the above 8 cases is tested using jest.
@skurfuerst
TASK: apply translation defaults in translate() method instead of in …
4e97dde 
…<I18n> helper

This is needed to ensure consistent programmatic access on localized labels
(e.g. in select editors, where we want to filter based on the translated string)
@skurfuerst
FEATURE: add "allowEmpty" in SelectBox and MultiSelectBox
ef2b670 
If allowEmpty is FALSE, we prevent removing the "last" element from the list.

For Single Select boxes, if displaySearchBox=true, we force allowEmpty to
be TRUE, as otherwise the search box would never be reachable after an element
was selected.

To migrate existing usages of Multi and Single select boxes, nothing needs to
be changed.
@skurfuerst
FEATURE: implement allowEmpty in Select Editor
f3bd386
@skurfuerst
BUGFIX: fix icons in MultiSelectBox
dbc061c
@skurfuerst skurfuerst mentioned this pull request Sep 6, 2017
Closed
@skurfuerst
Copy link
Member Author

Group support: #764

@skurfuerst skurfuerst mentioned this pull request Sep 6, 2017
Open
@skurfuerst skurfuerst changed the title WIP: Full select editor FEATURE: Full select editor (with data providers and multiselect support) Sep 6, 2017
This was referenced Sep 6, 2017
Closed
Closed
dimaip
dimaip approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@dimaip dimaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an eye of your work on this for a while, looked through it again. I propose to merge it now, and just follow up if we spot some bugs.
Looks pretty solid, exactly how I would have done it!

@skurfuerst
Copy link
Member Author

Thanks Dmitri <3 👍

@skurfuerst skurfuerst merged commit 16b22c8 into master Sep 6, 2017
@skurfuerst skurfuerst deleted the full-select-editor branch September 6, 2017 12:49
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaip dimaip dimaip approved these changes

Assignees

@skurfuerst skurfuerst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skurfuerst @dimaip