Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Groups in SelectBox #892

Closed
skurfuerst opened this issue Sep 6, 2017 · 9 comments
Closed

Implement Groups in SelectBox #892

skurfuerst opened this issue Sep 6, 2017 · 9 comments

Comments

@skurfuerst
Copy link
Member

skurfuerst commented Sep 6, 2017

<- must-have for 1.0.0

the old UI supported a "groups" key in the Select Box; which we do not support in the new UI yet.

It should be implemented in react-ui-components/SelectBox; as it will then automatically work for Select/MultiSelect editors.

I personally think it would be fine to deliver this feature after 1.0.

This is a reminder / follow-up for #764.

@dimaip
Copy link
Contributor

dimaip commented Sep 6, 2017

I agree, but still let's try to squeeze it in the end, if time would allow?
It would be so cool to have a feature-complete UI by 1.0!

@skurfuerst
Copy link
Member Author

A colleague of mine just learning react will tackle this in the upcoming days :) (Leon)

@skurfuerst skurfuerst self-assigned this Sep 11, 2017
@dimaip
Copy link
Contributor

dimaip commented Sep 12, 2017

Also take notice of this issue when working on it: #944

@klfman
Copy link
Contributor

klfman commented Sep 12, 2017

The issue does not comment on rules for sorting the options and/or groups in any particular order (e.g. alphabetically). Can anyone comment on this and tell me if I have to take care of sorting inside the component?

@skurfuerst
Copy link
Member Author

@klfman sorting groups based on "first group in list is displayed first", leaving options in the order they were provided :)

@dimaip dimaip added this to the 1.0.0 must haves milestone Oct 25, 2017
@dimaip
Copy link
Contributor

dimaip commented Oct 25, 2017

I'm adding this for 1.0, as we still have some time left, and this feature existed in the old UI, so would be sad if the new UI will not have it.

@dfeyer
Copy link
Contributor

dfeyer commented Nov 4, 2017

Check https://neos-project.slack.com/files/U4A2LD7QU/F7UV045EF/ui_select_box.mov the react UI as some kind of partial support of the grouping ;)

@skurfuerst
Copy link
Member Author

I think the grouping is basically implemented, but the keyboard-accessibility-change broke it again. Correct @mstruebing - could this be? :-)

@dimaip
Copy link
Contributor

dimaip commented Dec 1, 2017

Blocked by #1362

kitsunet added a commit that referenced this issue Dec 9, 2017
TASK: implement groups in SelectBox

Resolves: #892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants