-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Move access to objectAccess of TemplateObjectAccessInterface into getByPath #3041
Conversation
…into getByPath, as accessors are not used anymore for variable provider within fluid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, so fine if it works for you… 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, quickly tested this also with an application using Fluid.
As I found out today, this does not work when you use
|
Flow 8.x only works correctly with typo3fluid 2.7.x - see: neos/flow-development-collection#3038, neos/flow-development-collection#3041 and neos/flow-development-collection#3358
Flow 8.x only works correctly with typo3fluid 2.7.x - see: neos/flow-development-collection#3038, neos/flow-development-collection#3041 and neos/flow-development-collection#3358
... as accessors are not used anymore for variable provider within fluid, starting v2.8.0.
Due to the missing accessors the
objectAccess
ofTemplateObjectAccessInterface
didn't get called anymore, so the result of thegetByPath
method was an object ofFusionPathProxy
instead of an rendered string.See:
TYPO3/Fluid@2.7.4...2.8.0#diff-a0aa72aa19d9eb57cdb9a4dcd344c3706d75ae7ca408286f91a846e495b3c766L122
TYPO3/Fluid@2.7.4...2.8.0#diff-a0aa72aa19d9eb57cdb9a4dcd344c3706d75ae7ca408286f91a846e495b3c766L341
TYPO3/Fluid@2.7.4...2.8.0#diff-a0aa72aa19d9eb57cdb9a4dcd344c3706d75ae7ca408286f91a846e495b3c766L312