-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Prevent type hint errors with latest Fluid minor release #3038
Conversation
Thank you! |
Guess we should upmerge that immediately and release it to prevent more issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 A pity that's needed, though…
Why do we have that dependency in two places? |
You mean root of collection and fluidadaptor? For the split packages. Technically only the Adaptor depends on fluid, but composer doesn't understand our collections so for composer if you install the collection we need to mirror all dependencies from all included packages to the top level composer.json, there is a build script to do that automatically, you should normally not change the root collection composer.json by hand.
|
Flow 8.x only works correctly with typo3fluid 2.7.x - see: neos/flow-development-collection#3038, neos/flow-development-collection#3041 and neos/flow-development-collection#3358
Flow 8.x only works correctly with typo3fluid 2.7.x - see: neos/flow-development-collection#3038, neos/flow-development-collection#3041 and neos/flow-development-collection#3358
The 2.8.0 release of Fluid introduced breaking changes (type declarations), thus this changes the dependency to allow only 2.7.x.
Resolves: #3037
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions