Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "safekeeper: check for non-consecutive writes in safekeeper.rs" #8771

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Aug 20, 2024

Reverts #8640

This broke test_last_log_term_switch via a merge race of some kind.

@jcsp jcsp marked this pull request as ready for review August 20, 2024 10:25
@jcsp jcsp requested a review from a team as a code owner August 20, 2024 10:25
@jcsp jcsp requested a review from arssher August 20, 2024 10:25
@jcsp jcsp enabled auto-merge (squash) August 20, 2024 10:25
Copy link

github-actions bot commented Aug 20, 2024

2198 tests run: 2134 passed, 0 failed, 64 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_combocid: debug
  • test_forward_compatibility: debug
  • test_lfc_resize: debug
  • test_lagging_sk: debug

Code coverage* (full report)

  • functions: 32.4% (7235 of 22310 functions)
  • lines: 50.4% (58435 of 115922 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
19c9231 at 2024-08-20T11:42:48.119Z :recycle:

@jcsp jcsp merged commit 02a28c0 into main Aug 20, 2024
66 checks passed
@jcsp jcsp deleted the revert-8640-sk-check-non-consecutive-writes branch August 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants