-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safekeeper: check for non-consecutive writes in safekeeper.rs #8640
Conversation
wal_storage.rs already checks this, but since this is a quite legit scenario check it at safekeeper.rs (consensus level) as well. ref #8212
There was an idea to try to differ when these conditions are 'expected' and not, but I don't see a useful way to do this. It is normal to see this in case of reconnections. Something different is hard to imagine and likely means serious bug, like wal truncation repeatedly truncating not at the point where streaming later starts; then we won't be able to write anything at all and also notice the problem. |
2112 tests run: 2043 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
c10a29d at 2024-08-07T17:33:29.116Z :recycle: |
wal_storage.rs already checks this, but since this is a quite legit scenario check it at safekeeper.rs (consensus level) as well.
ref #8212