fix(highlight.vim): use default value for compose_hlgroup #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two hightlight groups both are empty or single reverse attribute,
`coc#highlight#compose_hlgroup` can't build new highlight group.
Such as:
```vim
hi Group1 gui=reverse
hi clear Group2
echo coc#highlight#compose_hlgroup('Group1', 'Group2')
```
will throw E411: highlight group not found: FgGroup1BgGroup2
Codecov Report
@@ Coverage Diff @@
## master #3514 +/- ##
=======================================
Coverage 74.74% 74.75%
=======================================
Files 191 191
Lines 19480 19480
Branches 4360 4360
=======================================
+ Hits 14561 14562 +1
Misses 3154 3154
+ Partials 1765 1764 -1
Continue to review full report at Codecov.
|
chemzqm
added a commit
that referenced
this pull request
Dec 21, 2021
077e470 fix(format): onTypeFormatting position (#3472) d5a4ee8 fix(float): check nvim 0.5.1 for zindex f59f77c fix(source-language): fix range of textEdit b532597 chore(handler): fix types for openCommand 4913238 chore(doc): add coc.preferences.semanticTokensHighlights cbd326b feat(typings): export SemanticTokensBuilder (#3357) 2ff2029 fix(api): preserve register content 19446d6 feat(sources): avoid \ as trigger character 69e8750 fix: typos in schema & docs (#3446) 8175e7a fix(highlight.vim): use default value for compose_hlgroup (#3514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two hightlight groups both are empty or single reverse attribute,
coc#highlight#compose_hlgroupcan't build new highlight group.Such as:
will throw E411: highlight group not found: FgGroup1BgGroup2