fix(format): onTypeFormatting position #3472
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neoclide/coc-yaml#51
I think the position used in
onTypeFormatting
is incorrect, in this fix, coc.nvim always uses the current position to request.I've tested with rust-analyzer/yaml, works as expected. But this fix introduced an unexpected behavior for TS with tsserver:
Put cursor on
if
, firecw
, theif
will be removed and enter insert mode, tsserver returns onTypeFormatting, after applied the edits, you got:the space after
if
is deleted too.The reason:
InsertEnter
andTextChangedI
, try to do onTypeFormatting foro
actioncw
also fires these two event, and tsserver reposed to do formatting