-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of bug fixes for the 2.4.2 release #744
Merged
Merged
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
31044c1
Fixed issue where table action rule creation modal displayed invalid …
nielsdejong b6b36f2
Add support for links in table actions, as well as improved rendering…
nielsdejong 78a56fd
No longer rendering empty buttons for missing values in table actions
nielsdejong 3b71740
Fix number formatting to always use en-US locale
nielsdejong 3f173ce
Fixed issue where dashboard database was not set correctly for share …
nielsdejong 013344c
Fixed dashboard title visibility in sidebar
nielsdejong 468540c
Added missing setting to pie chart configuration
nielsdejong 3e0e1ad
Clean up code, remove old console.log statements
nielsdejong 86dca1b
Stability and UX for table checkbox actiosn
nielsdejong 333f9e2
Handling shared dashboards in standalone mode
nielsdejong 17c27f6
Fixed sharing logic in both standalone and editor modes
nielsdejong fdc3be2
Added hidden setting for hiding the plaintext password warning. Fixed…
nielsdejong 2cf2ade
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong 3cd49c5
Style tweaks for reports without footers
nielsdejong a803f5f
Fixed styling defaults for bar chart
nielsdejong 2797f57
Fixed fullscreen views
nielsdejong 21efb64
Freetext parameter with manual save style fixes
nielsdejong f105717
clean up graph editing modal
nielsdejong 7f90d56
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong 7fd6998
Correction to release notes
nielsdejong 080fe49
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong ec7835f
Robustness of actions rule create modal
nielsdejong 910da66
Improved comments
nielsdejong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,21 @@ | ||
import React from 'react'; | ||
|
||
const canvasStyle = { paddingLeft: '10px', position: 'relative', overflow: 'hidden', width: '100%', height: '100%' }; | ||
const canvasStyle = { | ||
paddingLeft: '10px', | ||
marginBottom: 5, | ||
position: 'relative', | ||
overflow: 'hidden', | ||
width: '100%', | ||
height: '100%', | ||
}; | ||
|
||
/** | ||
* Renders the canvas on which the graph visualization is projected. | ||
*/ | ||
export const NeoGraphChartCanvas = ({ children }) => { | ||
return <div style={canvasStyle}>{children}</div>; | ||
return ( | ||
<div className='graph-chart-canvas' style={canvasStyle}> | ||
{children} | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,29 +251,28 @@ | |
} | ||
|
||
// When we are accessing node properties (not page names), parse the node label + property pair to only show properties. | ||
if (rule.customization !== 'set page') { | ||
if (rule.customization !== 'set page' && (type == 'graph' || type == 'map')) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. explain with a comment the filtering |
||
suggestions = suggestions.map((e) => e.split('.')[1] || e); | ||
} | ||
|
||
return suggestions; | ||
}; | ||
|
||
const handleOnInputchange = (customization, index, value) => { | ||
console.log(customization, index, value); | ||
updateRuleField(index, 'value', value); | ||
if (type == 'bar' && customization !== 'set page') { | ||
// For bar charts, duplicate the value to rule.field | ||
updateRuleField(index, 'field', value); | ||
} | ||
}; | ||
|
||
const handleOnChange = (customization, index, newValue) => { | ||
updateRuleField(index, 'value', newValue); | ||
}; | ||
|
||
const actionHelperClass = 'n-w-2/3 n-inline-flex'; | ||
const spanClass = 'n-align-middle '; | ||
const textInputClass = 'font-bold n-ml-2 n-mt-[1px] n-float-right n-w-full'; | ||
|
||
// Sets parameter value | ||
const getActionHelper = (rule, index, customization) => { | ||
|
@@ -334,9 +333,9 @@ | |
// Styling was then extracted into functions outside of the html components, hence the naming. | ||
const td2Styling = (type) => ({ width: type === 'bar' ? '15%' : '30%' }); | ||
const td2DropdownClassname = (type) => `n-align-middle n-pr-1 ${type === 'bar' ? 'n-w-full' : 'n-w-2/5'}`; | ||
const td2Autocomplete = (type, index, rule) => | ||
(type !== 'bar' ? ( | ||
<Autocomplete | ||
className='n-align-middle n-inline-block n-w-/5' | ||
disableClearable={true} | ||
id='autocomplete-label-type' | ||
|
@@ -349,14 +348,14 @@ | |
style={{ | ||
minWidth: 125, | ||
}} | ||
onInputChange={(event, value) => { | ||
updateRuleField(index, 'field', value); | ||
}} | ||
onChange={(event, newValue) => { | ||
updateRuleField(index, 'field', newValue); | ||
}} | ||
renderInput={(params) => ( | ||
<TextField | ||
{...params} | ||
placeholder='Field name...' | ||
style={{ padding: 0 }} | ||
|
@@ -365,10 +364,10 @@ | |
)} | ||
/> | ||
) : ( | ||
<></> | ||
)); | ||
const td4Styling = (type) => ({ width: type === 'bar' ? '45%' : '40%' }); | ||
const td4DropdownClassname = 'n-align-middle, n-w-1/3'; | ||
const td6Styling = (type) => ({ width: type === 'bar' ? '30%' : '20%' }); | ||
|
||
return ( | ||
|
@@ -492,10 +491,10 @@ | |
inputValue={rule.value || ''} | ||
popupIcon={<></>} | ||
style={{ minWidth: 250 }} | ||
onInputChange={(e, value) => handleOnInputchange(rule.customization, index, value)} | ||
onChange={(e, newValue) => handleOnChange(rule.customization, index, newValue)} | ||
renderInput={(params) => ( | ||
<TextField {...params} placeholder='Value name...' InputLabelProps={{ shrink: true }} /> | ||
)} | ||
/> | ||
</div> | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented code is needed?