Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of bug fixes for the 2.4.2 release #744

Merged
merged 23 commits into from
Jan 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
31044c1
Fixed issue where table action rule creation modal displayed invalid …
nielsdejong Jan 3, 2024
b6b36f2
Add support for links in table actions, as well as improved rendering…
nielsdejong Jan 3, 2024
78a56fd
No longer rendering empty buttons for missing values in table actions
nielsdejong Jan 3, 2024
3b71740
Fix number formatting to always use en-US locale
nielsdejong Jan 4, 2024
3f173ce
Fixed issue where dashboard database was not set correctly for share …
nielsdejong Jan 4, 2024
013344c
Fixed dashboard title visibility in sidebar
nielsdejong Jan 4, 2024
468540c
Added missing setting to pie chart configuration
nielsdejong Jan 4, 2024
3e0e1ad
Clean up code, remove old console.log statements
nielsdejong Jan 5, 2024
86dca1b
Stability and UX for table checkbox actiosn
nielsdejong Jan 10, 2024
333f9e2
Handling shared dashboards in standalone mode
nielsdejong Jan 10, 2024
17c27f6
Fixed sharing logic in both standalone and editor modes
nielsdejong Jan 10, 2024
fdc3be2
Added hidden setting for hiding the plaintext password warning. Fixed…
nielsdejong Jan 11, 2024
2cf2ade
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong Jan 11, 2024
3cd49c5
Style tweaks for reports without footers
nielsdejong Jan 11, 2024
a803f5f
Fixed styling defaults for bar chart
nielsdejong Jan 11, 2024
2797f57
Fixed fullscreen views
nielsdejong Jan 12, 2024
21efb64
Freetext parameter with manual save style fixes
nielsdejong Jan 12, 2024
f105717
clean up graph editing modal
nielsdejong Jan 12, 2024
7f90d56
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong Jan 12, 2024
7fd6998
Correction to release notes
nielsdejong Jan 12, 2024
080fe49
Merge branch 'develop' into feature/2.4.2-bug-fix-collection
nielsdejong Jan 12, 2024
ec7835f
Robustness of actions rule create modal
nielsdejong Jan 12, 2024
910da66
Improved comments
nielsdejong Jan 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed issue where table action rule creation modal displayed invalid …
…suggestions
  • Loading branch information
nielsdejong committed Jan 3, 2024
commit 31044c1e307934925777ba6bba7531407c0167e7
2 changes: 1 addition & 1 deletion src/extensions/actions/ActionsRuleCreationModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export const NeoCustomReportActionsModal = ({
}

// When we are accessing node properties (not page names), parse the node label + property pair to only show properties.
if (rule.customization !== 'set page') {
if (rule.customization !== 'set page' && (type == 'graph' || type == 'map')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain with a comment the filtering

suggestions = suggestions.map((e) => e.split('.')[1] || e);
}

Expand Down
Loading