Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 Release #688

Merged
merged 24 commits into from
Nov 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f151d32
Made API keys hidden (password fields) in the query translator module
nielsdejong Oct 10, 2023
0caa78a
Added new report action type for tables: multiselect checkboxes (#664)
nielsdejong Oct 27, 2023
3a2cf4d
Fix handling external updates of parameter values in parameter select…
nielsdejong Oct 27, 2023
5e27a02
Feature/new dashboard load UI (#657)
nielsdejong Oct 27, 2023
f4c2791
Bump @babel/traverse from 7.21.4 to 7.23.2 in /gallery (#670)
dependabot[bot] Nov 3, 2023
7b7bed1
Bump @babel/traverse from 7.20.13 to 7.23.2 (#669)
dependabot[bot] Nov 3, 2023
4f29427
Bump postcss from 8.4.23 to 8.4.31 in /gallery (#656)
dependabot[bot] Nov 6, 2023
f823de2
Bump postcss from 8.4.21 to 8.4.31 (#655)
dependabot[bot] Nov 6, 2023
e4b0ecd
Text hard to read on dark theme (#668)
JonanOribe Nov 6, 2023
96bd80b
Hotfix for wrong default parameter replacement in markdown
nielsdejong Nov 7, 2023
2d030a4
Merge branch 'develop' of github.com:neo4j-labs/neodash into develop
nielsdejong Nov 7, 2023
295857b
Add back arrow on connection modal (#675)
hugorplobo Nov 10, 2023
3742393
VULCAN-126/Override default message (#683)
nielsdejong Nov 10, 2023
be8b08f
Fix/hiding columns in table (#685)
AleSim94 Nov 13, 2023
ad4bd0b
Fix parameters values (#641)
BennuFire Nov 13, 2023
d7be8c7
Updated dashboard format to 2.4. Double resolution for horizontal and…
nielsdejong Nov 14, 2023
fceb5f3
Feature/gantt chart (#684)
alfredorubin96 Nov 14, 2023
c54acd3
adding in advanced config for the graph viz more graph layout config …
AleSim94 Nov 14, 2023
a6140d0
Adding form widget as a new extension (#568)
nielsdejong Nov 14, 2023
27d35f1
Model Examples and LLM improvements (#600)
alfredorubin96 Nov 15, 2023
85ff8fd
Merge branch 'master' into develop
nielsdejong Nov 16, 2023
9732c09
Added release notes for 2.4 + bonus feature (keyboard shortcut to run…
nielsdejong Nov 16, 2023
86cf207
Hotfixes for Sonarqube issues
nielsdejong Nov 16, 2023
85d9581
minor fix in the forms where it wasn't getting the correct value in t…
alfredorubin96 Nov 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix parameters values (#641)
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>
  • Loading branch information
BennuFire and nielsdejong authored Nov 13, 2023
commit ad4bd0b9f564fa99fe9cfa76d93282e68f2982da
11 changes: 9 additions & 2 deletions src/chart/parameter/component/NodePropertyParameterSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Autocomplete from '@mui/material/Autocomplete';
import { ParameterSelectProps } from './ParameterSelect';
import { RenderSubValue } from '../../../report/ReportRecordProcessing';
import { SelectionConfirmationButton } from './SelectionConfirmationButton';
import { getRecordType, toNumber } from '../../ChartUtils';

const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
const suggestionsUpdateTimeout =
Expand Down Expand Up @@ -105,18 +106,24 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
realValueRowIndex
];

newValue.push(RenderSubValue(val));
if (newValue.low) {
newValue.push(toNumber(val));
} else {
newValue.push(RenderSubValue(val));
}
} else if (!isMulti) {
newValue = extraRecords.filter((r) => (r?._fields?.[displayValueRowIndex]?.toString() || null) == newDisplay)[0]
._fields[realValueRowIndex];

newValue = RenderSubValue(newValue);
newValue = newValue.low ? toNumber(newValue) : RenderSubValue(newValue);
} else {
let ele = valDisplayReference.filter((x) => !newDisplay.includes(x))[0];
newValue = [...valReference];
newValue.splice(valDisplayReference.indexOf(ele), 1);
}

newDisplay = newDisplay.low ? toNumber(newDisplay) : RenderSubValue(newDisplay);

setInputDisplayText(isMulti ? '' : newDisplay);
setInputValue(newDisplay);

Expand Down
Loading