Hotfixes for Sonarqube issues

public/style.css

@@ -169,7 +169,6 @@
   overflow-x: scroll !important;
   overflow-y: scroll;
   min-height: 116px;
-  /*height: 200px !important;*/
 }
 
 .textinput-linenumbers::-webkit-scrollbar {

src/chart/parameter/ParameterSelectCardSettings.tsx

@@ -68,7 +68,7 @@ const ParameterSelectCardSettings = ({ query, database, settings, onReportSettin
         parameters,
         10,
         (status) => {
-          status == QueryStatus.NO_DATA ? setRecords([]) : null;
+          status == QueryStatus.NO_DATA ? setRecords([]) : () => {};
         },
         (result) => setRecords(result),
         () => {}

src/chart/parameter/component/NodePropertyParameterSelect.tsx

@@ -190,7 +190,7 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
             debouncedQueryCallback(props.query, { input: `${inputDisplayText}`, ...allParameters }, setExtraRecords);
           }
         }}
-        value={inputValue}
+        value={inputValue || ''}
         onChange={propagateSelection}
         renderInput={(params) => (
           <TextField

src/dashboard/DashboardThunks.ts

@@ -163,10 +163,8 @@ export const saveDashboardToNeo4jThunk = (driver, database, dashboard, date, use
       (records) => {
         if (records && records[0] && records[0]._fields && records[0]._fields[0] && records[0]._fields[0] == uuid) {
           dispatch(createNotificationThunk('🎉 Success!', 'Your current dashboard was saved to Neo4j.'));
-
           onSuccess(uuid);
         } else {
-          console.log(records);
           dispatch(
             createNotificationThunk(
               'Unable to save dashboard',
@@ -200,7 +198,6 @@ export const deleteDashboardFromNeo4jThunk = (driver, database, uuid, onSuccess)
         if (records && records[0] && records[0]._fields && records[0]._fields[0] && records[0]._fields[0] == uuid) {
           onSuccess(uuid);
         } else {
-          console.log(records);
           dispatch(
             createNotificationThunk(
               'Unable to delete dashboard',

src/dashboard/sidebar/DashboardSidebar.tsx

@@ -119,7 +119,7 @@ export const NeoDashboardSidebar = ({
     // Creates new dashboard in draft state (not yet saved to Neo4j)
     deleteDashboardFromNeo4j(driver, dashboardDatabase, uuid, () => {
       if (uuid == dashboard.uuid) {
-        setSelectedDashboardIndex[0];
+        setSelectedDashboardIndex(0);
         resetLocalDashboard();
         setDraft(true);
       }
@@ -324,11 +324,7 @@ export const NeoDashboardSidebar = ({
             }}
             handleImportClicked={() => {
               setMenuOpen(Menu.NONE);
-              if (draft) {
-                setModalOpen(Modal.IMPORT);
-              } else {
-                setModalOpen(Modal.IMPORT);
-              }
+              setModalOpen(Modal.IMPORT);
             }}
             handleClose={() => {
               setMenuOpen(Menu.NONE);

src/dashboard/sidebar/modal/legacy/LegacyShareModal.tsx

@@ -114,7 +114,7 @@ export const NeoShareModal = ({ open, handleClose, connection }) => {
               defaultValue={'No'}
               choices={['Yes', 'No']}
               onChange={(e) => {
-                if ((e == 'No') & (shareStandalone == 'Yes')) {
+                if (e == 'No' && shareStandalone == 'Yes') {
                   return;
                 }
                 setShareLink(null);

src/report/Report.tsx

@@ -211,7 +211,7 @@ export const NeoReport = ({
         parameters,
         1000,
         (status) => {
-          status == QueryStatus.NO_DATA ? setRecords([]) : null;
+          status == QueryStatus.NO_DATA ? setRecords([]) : () => {};
         },
         (result) => setRecords(result),
         () => {},