Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5.x drop annotations #2363

Merged
merged 36 commits into from
Oct 25, 2024
Merged

feat: 5.x drop annotations #2363

merged 36 commits into from
Oct 25, 2024

Conversation

DjordyKoert
Copy link
Collaborator

@DjordyKoert DjordyKoert commented Oct 22, 2024

Drops annotations for major 5.x

#2215

@DjordyKoert DjordyKoert changed the base branch from master to 5.x October 22, 2024 15:00
@DjordyKoert
Copy link
Collaborator Author

DjordyKoert commented Oct 24, 2024

some failing tests will be fixed by bumping willdurand/hateoas / willdurand/hateoas-bundle after willdurand/Hateoas#334 is merged.

edit: Maybe restrict it to the beta release for now? willdurand/BazingaHateoasBundle#104 (comment)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (7ea79f5) to head (3a92db9).
Report is 1 commits behind head on 5.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              5.x    #2363      +/-   ##
==========================================
- Coverage   89.34%   89.33%   -0.02%     
==========================================
  Files          73       73              
  Lines        2834     2775      -59     
==========================================
- Hits         2532     2479      -53     
+ Misses        302      296       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert marked this pull request as ready for review October 25, 2024 11:00
@DjordyKoert DjordyKoert merged commit d8e9e29 into 5.x Oct 25, 2024
17 checks passed
@DjordyKoert DjordyKoert deleted the 5.x-drop-annotations branch October 25, 2024 11:01
@W0rma
Copy link

W0rma commented Nov 4, 2024

@DjordyKoert FYI willdurand/hateoas-bundle:2.7.0-beta2 makes it possible to install the bundle without doctrine/annotations

@DjordyKoert
Copy link
Collaborator Author

@DjordyKoert FYI willdurand/hateoas-bundle:2.7.0-beta2 makes it possible to install the bundle without doctrine/annotations

Thanks for the heads-up! 😄
I was already subscribed to the PR & 5.x branch should use it

"willdurand/hateoas-bundle": "^2.7@beta",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants