Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make doctrine/annotations optional + drop PHP < 8.1 #110

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Oct 31, 2024

Follow-up of willdurand/Hateoas#334

@W0rma W0rma force-pushed the optional-doctrine-annotations branch from 6140b7c to 4be102f Compare November 1, 2024 08:12
@W0rma
Copy link
Contributor Author

W0rma commented Nov 1, 2024

Jobs with symfony ^3.0 and ^4.0 fail if doctrine/annotations package is not installed.
Looks like this is because jms/serializer-bundle:4.2 does not really work without this package.

Tests with serializer-bundle v3 and v5 look fine.

@goetas Do you think it's worth the effort to look into the issue with v4.2 or is it sufficient to have the tests without annotations only for symfony ^5.0 and higher?

@goetas
Copy link
Collaborator

goetas commented Nov 1, 2024

Running tests on most recent symfony versions is more than acceptable.

I would not mind dropping old php and symfony versions as well (if it helps you here)

…5/6/7

jms/serializer-bundle:4.2 which is installed when using older symfony versions does not seem to work without annotations package
@goetas
Copy link
Collaborator

goetas commented Nov 3, 2024

Hi, thanks a lot, I will check it later in the evening

@W0rma W0rma marked this pull request as ready for review November 3, 2024 09:19
@W0rma
Copy link
Contributor Author

W0rma commented Nov 3, 2024

Tests are green.

All supported symfony versions are still tested.
The tests without doctrine/annotations package are only executed with symfony 5 and higher.

I tested the code in my personal project and it worked fine.
Please note that I neither use attributes nor annotations in my project.

@goetas goetas merged commit d00ab70 into willdurand:master Nov 4, 2024
39 checks passed
@goetas
Copy link
Collaborator

goetas commented Nov 4, 2024

I could not spot anything wrong, great work! thank you!

@W0rma W0rma deleted the optional-doctrine-annotations branch November 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants