-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make doctrine/annotations optional + drop PHP < 8.1 #110
Conversation
6140b7c
to
4be102f
Compare
Jobs with symfony ^3.0 and ^4.0 fail if Tests with serializer-bundle v3 and v5 look fine. @goetas Do you think it's worth the effort to look into the issue with v4.2 or is it sufficient to have the tests without annotations only for symfony ^5.0 and higher? |
Running tests on most recent symfony versions is more than acceptable. I would not mind dropping old php and symfony versions as well (if it helps you here) |
…5/6/7 jms/serializer-bundle:4.2 which is installed when using older symfony versions does not seem to work without annotations package
Hi, thanks a lot, I will check it later in the evening |
Tests are green. All supported symfony versions are still tested. I tested the code in my personal project and it worked fine. |
I could not spot anything wrong, great work! thank you! |
Follow-up of willdurand/Hateoas#334