Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Caption in the top-right menu is truncated #138

Closed
bdaase opened this issue Dec 4, 2021 · 9 comments · Fixed by #133
Closed

[BUG] Caption in the top-right menu is truncated #138

bdaase opened this issue Dec 4, 2021 · 9 comments · Fixed by #133
Labels

Comments

@bdaase
Copy link

bdaase commented Dec 4, 2021

Describe the bug

Since not so long ago, the caption in the top-right menu is truncated.

Screenshots

image

To Reproduce

  1. Click the icon in the top panel

Desktop (please complete the following information):

  • Fedora 35
  • Gnome 41.1
  • Extension Version 36

Additional context

This started to happen quite recently, but I have no idea what has actually changed in between...

@bdaase bdaase added the bug label Dec 4, 2021
@bdaase bdaase changed the title [BUG] [BUG] Caption in the top-right menu is truncated Dec 4, 2021
@neffo
Copy link
Owner

neffo commented Dec 4, 2021

Strange, don't see it in English on GNOME 40.5.

image

What do you see if you hover over the image in the image gallery? I presume this is the German language/German Bing market?

I see this (in English):
image

@bdaase
Copy link
Author

bdaase commented Dec 4, 2021

Yeah, it's German locale.

Everything looks fine in the image gallery

image

@bdaase
Copy link
Author

bdaase commented Dec 4, 2021

It's also truncated in English btw

image

@neffo
Copy link
Owner

neffo commented Dec 4, 2021

Ahh, this must be a GNOME 41 thing.

I see this with the German locale:
image

And in GNOME 41 VM machine, I see this:
image

@bdaase
Copy link
Author

bdaase commented Dec 4, 2021

Glad that you can reproduce it 👍

@neffo
Copy link
Owner

neffo commented Dec 4, 2021

Yeah, thanks for reporting it. This seems like it could be a bug that was introduced in St.Label or some CSS. It's strange as the line looks like it has expanded vertically, but hasn't wrapped the text.

@neffo
Copy link
Owner

neffo commented Dec 5, 2021

May have found a fix for it:
image

@neffo neffo mentioned this issue Dec 11, 2021
20 tasks
@neffo neffo linked a pull request Dec 11, 2021 that will close this issue
20 tasks
@bdaase
Copy link
Author

bdaase commented Dec 11, 2021

Looks like the problem was fixed by a recent GNOME update?

image

I quickly grepped through my update history and the only change that might explain it, is the update from pango-1.49.3-2.fc35.x86_64 to pango-1.50.0-1.fc35.x86_64.

So maybe a fix in the extension isn't even required. Sorry for the noise...

@neffo
Copy link
Owner

neffo commented Dec 11, 2021

Interesting, I tested on the GNOME OS nightly to replicate it, so it's a very recent fix.

No problem at all, this label wasn't sized correctly anyway, so should look better in this version when word-wrapped.

neffo added a commit that referenced this issue Dec 14, 2021
* Updated Swedish translation (#129) #14
* fix build instructions
* remove lockscreen switch
* use arrow functions
* fix carousel, add view image button to gallery
* fix purging of old images
* fix missing declaration, carousel image sort
* fix image cleanup #134
* fix deleteImage call
* fix gtk3 gui issues
* fix hidden elements in gtk4 settings
* add info button to gallery
* improved debug logging
* dont save thumbs if delete-previous enabled
* fix notify, opening images, & broken about logo
* remove action from notification
* update german translation (#137)
* initial test import and export of JSON data #136
* fix bytearray toString() warnings
* try fix ellipsized image labels #138
* purge missing files from imported image list
* export bing.json by default
* togglable auto export of JSON data and thumbnails
* set background option in prefs fixes and don't force background zoom #38
* fix missing declaration
* clean up gtk3 settings
* unneeded method, fix icon switching and gtk4 prefs
* code clean up remove unneeded code
* switch to current image if invalid
* remove functions implemented in extensionUtils.js
* fix build script
* code clean up
* fix timeout reversions
* fix carousel thumbnail logic
* small tweaks to gallery ui

Co-authored-by: krevad <krevad@users.noreply.github.com>
Co-authored-by: JAKuhr <9527705+JAKuhr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants