Revert "json: remove deprecated old style path+data request format" #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@posvyatokum, we’ll need another rc with this cherry picked. |
matklad
reviewed
Oct 10, 2022
| /// Deprecated. If you want to decode a CryptoHash, use CryptoHash::from_str. | ||
| /// For anything else, don’t use base58. This is still here because of | ||
| /// deprecated RPC query format in RpcQueryRequest::parse. | ||
| pub fn from_base58(s: &str) -> Result<Vec<u8>, Box<dyn std::error::Error + Send + Sync>> { |
There was a problem hiding this comment.
In a follow-up, lets move this closed to the use-site, so that we don't have to mark it as deprecated
There was a problem hiding this comment.
Counter argument though is that it would add direct bs58 dependency in chain/jsonrpc which we’ll forget to remove once from_base58 is removed.
matklad
approved these changes
Oct 10, 2022
|
@mina86 Testnet will switch to new protocol version in the next epoch. If everything goes well, I imagine doing a release a day after that, so on Wednesday. If something breaks with protocol upgrade, the release date will be determined by that bugfix. Is that timeline ok or is this more urgent? |
|
Sure. Most importantly is that this revert gets into mainnet release. |
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there still are users of the old query format. Bring it back.
This reverts commit be8a1ea.
Fixes: #7769