Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated old style path+data JSON query request format #7812

Open
mina86 opened this issue Oct 12, 2022 · 1 comment
Open

Deprecated old style path+data JSON query request format #7812

mina86 opened this issue Oct 12, 2022 · 1 comment
Labels
Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team

Comments

@mina86
Copy link
Contributor

mina86 commented Oct 12, 2022

#7601 removed an undocumented format for doing RPC query requests but turns out some clients were still using it so it got reverted in #7797. We might want to come up with some plan of deprecating that format and getting rid of the code.

@mina86 mina86 added the P-low Priority: low label Oct 12, 2022
@matklad
Copy link
Contributor

matklad commented Oct 12, 2022

Two thoughts here:

  • we might actually leave it be? This is surface-only functionality, so it's not like we gain a lot from actually removing support here.
  • we can add probabalistic failures: eg, fail 0.1% of requests with a clear error message, ramp that up over sereval releses to 50%, then remove.

Retrospectively and as a lesson for the future, #7601 should probably have kept the parsing code in to return a clear error message.

@nikurt nikurt added the T-node Team: issues relevant to the node experience team label Oct 12, 2022
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team
Projects
None yet
Development

No branches or pull requests

4 participants