Fix ldso configuration parsing for musl binaries #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, lddtree always checked for the glibc library paths, even when ran on a musl binary. This resulted in incorrect results on multiarch systems with both musl and glibc.
|
can you please rebase this? |
|
also, bad things happens if |
|
never mind i rebased it myself in #18 and added handling of missing ldso conf |
|
this was fixed in #18 which also adds tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lddtree always checked for the glibc library paths, even
when ran on a musl binary. This resulted in incorrect results on
multiarch systems with both musl and glibc.