-
Notifications
You must be signed in to change notification settings - Fork 20
StudioEtrange #1 - Three New options #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For binutils, why do you use objdump AND readelf ? Second remard : RUNPATH or RPATH, could have a list of path, so sed expressions to replace ORIGIN needs g flag Third remark : ORIGIN value in rpath could be "ORIGIN" or in very rare case I have met "{ORIGIN}" According to you answer, i will do a second PR |
Because the I am ok with a patch to only use
That would been nice to have in separate commit with a clear commit message.
Does this also happen with |
|
I suggest that we go forward with those steps:
Also, please try avoid add/remove whitespace unless there is good reason to do so. It only slows down the review process. Thanks! |
|
Third remark : ORIGIN value in rpath could be "ORIGIN" or in very rare case I have met "{ORIGIN}" Yes, it is hardcoded in binary. it is the value in RUNPATH or RPATH as is "{ORIGIN}" |
|
Sorry, I give up. I do not have enough time to follow your guidelines, and group/edit commit and message. |
Ok, then
First PR in my attempt to merge my stuff upstream.
This PR is about 3 new options
I made 3 commits, one for each option, and 1 more for help and readme
--no-header which do not print binary info and its interpreter
--no-recursive to not parse dependencies of dependencies
-b to force use of a specific backend tools (so no, auto fallback)