-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/sqs #262
Refactoring/aws/sqs #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I didn't approve right away because think it's really important to separate the concerns. Also the build is broken what's up with that.
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #262 +/- ##
================================================================
+ Coverage 31.76% 31.78% +0.01%
================================================================
Files 146 147 +1
Lines 5805 5827 +22
================================================================
+ Hits 1844 1852 +8
- Misses 3961 3975 +14
Continue to review full report at Codecov.
|
This PR aims to migrate AWS SQS service to the new architecture, as part of #183.