-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/elb #257
Refactoring/aws/elb #257
Conversation
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #257 +/- ##
================================================================
+ Coverage 31.32% 31.67% +0.35%
================================================================
Files 140 143 +3
Lines 5784 5761 -23
================================================================
+ Hits 1812 1825 +13
+ Misses 3972 3936 -36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 💯
This PR aims to migrate AWS ELB service to the new architecture, as part of #183.
Please note that I got rid of the elb policies since they weren't used anywhere.