Fix #624, add compatibility for CFS app doc build #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly pre-build the "osal_public_api_headerlist" target which will fix documenation workflows that have not been updated to include this dependency.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Dec 6, 2022
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
dzbaker
added a commit
that referenced
this pull request
Dec 6, 2022
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Explicitly pre-build the "osal_public_api_headerlist" target which will fix documenation workflows that have not been updated to include this dependency.
Fixes #624
Testing performed
Build documentation
Expected behavior changes
CFS app doc builds should now all work again, until they can be updated properly
System(s) tested on
Github hosted runner
Additional context
This is gated by a boolean to make it easier to run app builds WITHOUT this, in order to test the workflow after putting in the real fix.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.