Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2214, add abstract documentation dependency target #2215

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Adds a top level target called "doc-prebuild" which in turn can be made to depend on any other files that need to exist before documentation can be built.

Fixes #2214

Testing performed
Build documentation

Expected behavior changes
Abstract dependency target now provided

System(s) tested on
Ubuntu 22.04

Additional context
needs to be merged with nasa/osal#1341 to work correctly.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Adds a top level target called "doc-prebuild" which in turn can be made
to depend on any other files that need to exist before documentation can
be built.
@jphickey jphickey added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) dependency labels Nov 25, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 1, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 6, 2022
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker merged commit 70906a7 into nasa:main Dec 6, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 6, 2022
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
@jphickey jphickey deleted the fix-2214-doc-dependency-tgt branch February 1, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB dependency draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add abstract target for documentation dependencies
3 participants