Skip to content

Add import_site_packages option#4

Merged
amerry merged 1 commit intonanoporetech:mainfrom
micolous:import-site-packages
Mar 20, 2025
Merged

Add import_site_packages option#4
amerry merged 1 commit intonanoporetech:mainfrom
micolous:import-site-packages

Conversation

@micolous
Copy link
Contributor

This option allows the plugin to build Protocol Buffer definitions which contain imports in packages that are published with both .proto and _pb2.py files, such as googleapis-common-protos, without rebuilding everything and stomping existing paths.

While here, note that proto_paths does not follow symlinks.

Copy link
Member

@amerry amerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, and apologies for not reviewing it sooner (apparently I didn't have a watch on the repo...). This looks great - thanks especially for the work you put in to the documentation!

@amerry amerry merged commit 4d9cea9 into nanoporetech:main Mar 20, 2025
1 check passed
@micolous
Copy link
Contributor Author

No worries. The delay ended up being slightly fortuitous, because googleapis-common-protos broke this for a few releases (>= 1.67.0, < 1.69.1) after they changed their build pipeline. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants