Skip to content

add completion function #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024
Merged

add completion function #5

merged 2 commits into from
Mar 4, 2024

Conversation

bachvudinh
Copy link
Collaborator

As requested in #4, I created a function called completion to receive prompt input and return the output string. Thanks to @phamson02 for working with me on my first commit and my first time diving into a C++ project.

@namtranase namtranase self-requested a review March 3, 2024 03:49
@namtranase
Copy link
Owner

Thank the team for the hard work. I read your code and have a few suggestions, please consider:

  • We can make a class Model to hold all parameters of the model and make sure it has key functions like completion, chat, batching...
    -> This makes sure that you don't need to re-load the model each time you do inference.

@namtranase namtranase merged commit 24a7940 into master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants