Skip to content

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Oct 1, 2025

Describe your changes

Closes #4450.

Removes handling of failed atomic batches from handle_inner_tx_results that was never used

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@grarco grarco requested a review from tzemanovic October 1, 2025 10:08
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Oct 1, 2025
Copy link
Contributor

mergify bot commented Oct 1, 2025

🧪 CI Insights

Here's what we observed from your CI run for 2836176.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@tzemanovic tzemanovic added the backport-201.0 Backport to app 201.0 maintenance branch label Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 1, 2025
@mergify mergify bot added the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
Copy link
Contributor

mergify bot commented Oct 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #4879.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Oct 1, 2025

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify bot removed the queued label Oct 1, 2025
@tzemanovic
Copy link
Collaborator

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Oct 1, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
Copy link
Contributor

mergify bot commented Oct 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #4880.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Oct 1, 2025

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify bot removed the queued label Oct 1, 2025
@tzemanovic
Copy link
Collaborator

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Oct 1, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
@mergify mergify bot merged commit e6f0378 into main Oct 1, 2025
26 of 27 checks passed
@mergify mergify bot deleted the grarco/unused-batch-handling branch October 1, 2025 19:46
@mergify mergify bot removed the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 3, 2025
Refactor handling of failed atomic batches (backport #4877)
mergify bot added a commit that referenced this pull request Oct 3, 2025
…pr-4877

Refactor handling of failed atomic batches (backport #4877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-201.0 Backport to app 201.0 maintenance branch backport-libs-0.251 Backport libraries to 0.251 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change refactor / code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Useless handling of failed atomic batches

2 participants