Skip to content

Useless handling of failed atomic batches #4450

@grarco

Description

@grarco

In handle_inner_tx_results https://github.com/anoma/namada/blob/5c15d2ab3c7a62f3d2d81d9d660c58828f65c1c7/crates/node/src/shell/finalize_block.rs#L442

we manage the case of a failed atomic batch. The dispatch_inner_txs function though https://github.com/anoma/namada/blob/5c15d2ab3c7a62f3d2d81d9d660c58828f65c1c7/crates/node/src/protocol.rs#L333 returns an error in that case and so we end up calling handle_batch_error https://github.com/anoma/namada/blob/5c15d2ab3c7a62f3d2d81d9d660c58828f65c1c7/crates/node/src/shell/finalize_block.rs#L509 not handle_inner_tx_results therefore we don't need to handle this case in there

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions