Conversation
Some refactors: - Move code around so that helpers structs come after the Connection, kind of more the style and keeps connection code more together. - Use some defensive coding in the spaces impls. Fix a few bugs detected by it
flub
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/450/docs/iroh_quinn/ Last updated: 2026-02-23T13:29:40Z |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 77.45% 77.48% +0.03%
==========================================
Files 81 81
Lines 23411 23465 +54
==========================================
+ Hits 18132 18181 +49
- Misses 5279 5284 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Performance Comparison Report
|
| Scenario | iroh-quinn | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5441.5 Mbps | 7775.5 Mbps | -30.0% | 92.7% / 97.4% |
| medium-concurrent | 5515.6 Mbps | 7816.7 Mbps | -29.4% | 93.2% / 97.8% |
| medium-single | 3814.0 Mbps | 4662.4 Mbps | -18.2% | 90.5% / 97.8% |
| small-concurrent | 3714.9 Mbps | 5182.1 Mbps | -28.3% | 93.3% / 103.0% |
| small-single | 3366.6 Mbps | 4760.5 Mbps | -29.3% | 89.7% / 96.7% |
Netsim Benchmarks (network simulation)
| Condition | iroh-quinn | upstream | Delta |
|---|---|---|---|
| ideal | N/A | 4019.8 Mbps | N/A |
| lan | N/A | 810.4 Mbps | N/A |
| lossy | N/A | 55.9 Mbps | N/A |
| wan | N/A | 83.8 Mbps | N/A |
Summary
iroh-quinn is 27.6% slower on average
matheus23
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some refactors:
kind of more the style and keeps connection code more together.
detected by it
Breaking Changes
n/a
Notes & open questions
Split off from #444 even though that's still only draft.
Ugh, I guess given the fixes this should really be split in two again? 😭
Someone please just approve... 🥺