fix: improve packet scheduling for not-validated paths#444
Draft
fix: improve packet scheduling for not-validated paths#444
Conversation
so let's check in totally broken code.
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | N/A | 7935.4 Mbps | N/A | N/A |
| medium-concurrent | N/A | 7741.4 Mbps | N/A | N/A |
| medium-single | N/A | 4749.1 Mbps | N/A | N/A |
| small-concurrent | N/A | 5259.7 Mbps | N/A | N/A |
| small-single | N/A | 4709.0 Mbps | N/A | N/A |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | N/A | 4008.8 Mbps | N/A |
| lan | N/A | 810.4 Mbps | N/A |
| lossy | N/A | 55.9 Mbps | N/A |
| wan | N/A | 83.8 Mbps | N/A |
b67d78083f447c69f2dc68dcc918955984ec5b2f - artifacts
No results available
c3eed892cf6ab907aeb98ecea15d44d7548c6654 - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | N/A | 7871.6 Mbps | N/A | N/A |
| medium-concurrent | N/A | 7738.9 Mbps | N/A | N/A |
| medium-single | N/A | 4612.9 Mbps | N/A | N/A |
| small-concurrent | N/A | 5073.2 Mbps | N/A | N/A |
| small-single | N/A | 4709.9 Mbps | N/A | N/A |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 748.4 Mbps | 3980.5 Mbps | -81.2% |
| lan | 572.7 Mbps | 800.6 Mbps | -28.5% |
| lossy | 69.9 Mbps | 69.9 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 70.1% slower on average
453fa89b88ef3d18fb15da390fd464e916bc5d1f - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | N/A | 7916.7 Mbps | N/A | N/A |
| medium-concurrent | N/A | 7605.0 Mbps | N/A | N/A |
| medium-single | N/A | 4749.1 Mbps | N/A | N/A |
| small-concurrent | N/A | 5384.7 Mbps | N/A | N/A |
| small-single | N/A | 4844.6 Mbps | N/A | N/A |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 739.2 Mbps | 3951.3 Mbps | -81.3% |
| lan | 572.7 Mbps | 810.3 Mbps | -29.3% |
| lossy | 55.9 Mbps | 55.9 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 70.4% slower on average
matheus23
reviewed
Feb 23, 2026
matheus23
reviewed
Feb 23, 2026
Member
|
I know this is WIP code, but I want to call out that this contains partly some really useful refactors (moving Stacking these two in separate stacked PRs might make it easier to review. I know this is draft - so feel free to ignore me :) |
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/444/docs/noq/ Last updated: 2026-03-09T16:25:18Z |
This stopped us from going to the next space to coalesce the Initial with the Handshake packet on the server-side. And probably lots of other stuff
Turns out this was exactly the same case as SendableFrames::space_id_only.
Slightly sad to have to make an explicit exception for this, at least currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wip
Breaking Changes
Notes & open questions
it's the weekend, this is useful in my head
so let's check in totally broken code.