Skip to content

plugin section for the eslintrc file in the README #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

plugin section for the eslintrc file in the README #120

wants to merge 1 commit into from

Conversation

cirpo
Copy link

@cirpo cirpo commented May 26, 2018

  • better markdown table formatting

- better markdown table formatting
@cirpo
Copy link
Author

cirpo commented May 26, 2018

I was getting

  1:1  error  Definition for rule 'node/no-deprecated-api' was not found        node/no-deprecated-api
  1:1  error  Definition for rule 'node/no-extraneous-require' was not found    node/no-extraneous-require
  1:1  error  Definition for rule 'node/no-missing-require' was not found       node/no-missing-require
  1:1  error  Definition for rule 'node/no-unpublished-bin' was not found       node/no-unpublished-bin
  1:1  error  Definition for rule 'node/no-unpublished-require' was not found   node/no-unpublished-require
  1:1  error  Definition for rule 'node/no-unsupported-features' was not found  node/no-unsupported-features
  1:1  error  Definition for rule 'node/process-exit-as-throw' was not found    node/process-exit-as-throw
  1:1  error  Definition for rule 'node/shebang' was not found                  node/shebang

@mysticatea I spent quite some time to figure out that the error was just because I forgot to import the plugin in the eslintrc, maybe this PR will save some other people's time :P

@codecov-io
Copy link

codecov-io commented May 26, 2018

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          43       43           
  Lines        1117     1117           
=======================================
  Hits         1072     1072           
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e957849...132d5db. Read the comment docs.

@mysticatea
Copy link
Owner

Thank you for this PR.

However,

@cirpo
Copy link
Author

cirpo commented May 26, 2018

@mysticatea in the meantime I'm going to open a PR adding only the "plugin" part. thanks

@mysticatea
Copy link
Owner

Please check #116, about "plugin" part.

9425f68 added plugins: ["node"] to the recommended config, but I have not published it. I will publish it at the next major release I'm writing to support Node 10 things.
#116 (comment)

@cirpo
Copy link
Author

cirpo commented May 26, 2018

👍

@cirpo cirpo closed this May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants