Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with .eslintrc.json plugin field #116

Closed
wants to merge 1 commit into from
Closed

Update README.md with .eslintrc.json plugin field #116

wants to merge 1 commit into from

Conversation

alinchican
Copy link

@alinchican alinchican commented Apr 29, 2018

.eslintrc.json example found on npm contains an additional field named plugins which can't be found in the README.md.

Without it, I'm getting the following errors:

  1:1  error  Definition for rule 'node/no-extraneous-require' was not found    node/no-extraneous-require
  1:1  error  Definition for rule 'node/no-missing-require' was not found       node/no-missing-require
  1:1  error  Definition for rule 'node/no-unpublished-bin' was not found       node/no-unpublished-bin
  1:1  error  Definition for rule 'node/no-unpublished-require' was not found   node/no-unpublished-require
  1:1  error  Definition for rule 'node/no-unsupported-features' was not found  node/no-unsupported-features
  1:1  error  Definition for rule 'node/process-exit-as-throw' was not found    node/process-exit-as-throw
  1:1  error  Definition for rule 'node/shebang' was not found                  node/shebang

The plugin field was proposed to be deleted in #113 and deleted in 9425f68.

I''ve tried switching from node 10 to node 8 and replacing yarn with npm. I've also tried switching from .eslintrc.js to .eslintrc.json. I'm using macOS 10.13.4

Adding "plugins": ["node"], fixed it. I can't spend more time investigating other scenarios. Am I doing something wrong? 🤔

My package.json looks like this

"eslint": "^4.19.1",
"eslint-config-prettier": "^2.9.0",
"eslint-plugin-jest": "^21.15.1",
"eslint-plugin-node": "^6.0.1",
"eslint-plugin-prettier": "^2.6.0",
"jest": "^22.4.3",
"prettier": "^1.12.1"

My .eslintrc.js looks like this

module.exports = {
  "env": {
    "es6": true,
    "node": true,
    "jest": true
  },
  "extends": [
    "eslint:recommended",
    "plugin:prettier/recommended",
    "plugin:jest/recommended",
    "plugin:node/recommended"
  ]
};

@codecov-io
Copy link

codecov-io commented Apr 29, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          43       43           
  Lines        1066     1066           
=======================================
  Hits         1047     1047           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019ddd3...7315ee7. Read the comment docs.

@alinchican
Copy link
Author

alinchican commented Apr 29, 2018

I'm not sure if this is intended since the packet version found on npm is 6.0.1 and I might have read the README.md file for curent/future unpublished version.

@aladdin-add
Copy link
Contributor

well, same in eslint/eslint-cli#9 .

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mysticatea
Copy link
Owner

Oh, I'm sorry that I have overlooked this issue.

9425f68 added plugins: ["node"] to the recommended config, but I have not published it. I will publish it at the next major release I'm writing to support Node 10 things.

Thank you.

@mysticatea mysticatea closed this May 15, 2018
ota-meshi pushed a commit to ota-meshi/eslint-plugin-node that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants