Skip to content

Remove DATETIME_PRECISION as it's not present in MySQL 5.5 #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove DATETIME_PRECISION as it's not present in MySQL 5.5 #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f005c4
Remove DATETIME_PRECISION as it's not present in MySQL 5.5
malessainray Jul 18, 2022
687b65a
Fix UnitTest MySQL 5.5 compatibility
malessainray Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/MySqlConnector/Core/SchemaProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ private async Task FillColumns(IOBehavior ioBehavior, DataTable dataTable, Cance
new("CHARACTER_MAXIMUM_LENGTH", typeof(long)),
new("NUMERIC_PRECISION", typeof(ulong)),
new("NUMERIC_SCALE", typeof(ulong)),
new("DATETIME_PRECISION", typeof(uint)),
new("CHARACTER_SET_NAME", typeof(string)),
new("COLLATION_NAME", typeof(string)),
new("COLUMN_TYPE", typeof(string)),
Expand Down Expand Up @@ -359,7 +358,6 @@ private async Task FillParameters(IOBehavior ioBehavior, DataTable dataTable, Ca
new("CHARACTER_OCTET_LENGTH", typeof(long)),
new("NUMERIC_PRECISION", typeof(int)),
new("NUMERIC_SCALE", typeof(int)),
new("DATETIME_PRECISION", typeof(int)),
new("CHARACTER_SET_NAME", typeof(string)),
new("COLLATION_NAME", typeof(string)),
new("DTD_IDENTIFIER", typeof(string)),
Expand Down
1 change: 0 additions & 1 deletion tests/SideBySide/SchemaProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public void ColumnsSchema()
AssertHasColumn("CHARACTER_MAXIMUM_LENGTH", typeof(long));
AssertHasColumn("NUMERIC_PRECISION", typeof(ulong));
AssertHasColumn("NUMERIC_SCALE", typeof(ulong));
AssertHasColumn("DATETIME_PRECISION", typeof(uint));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code exists to verify that changes haven't introduced a regression; you can't just delete it to make the tests pass.

AssertHasColumn("CHARACTER_SET_NAME", typeof(string));
AssertHasColumn("COLLATION_NAME", typeof(string));
AssertHasColumn("COLUMN_KEY", typeof(string));
Expand Down