Remove DATETIME_PRECISION as it's not present in MySQL 5.5 #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Malessa <malessa@inray.de>
Signed-off-by: Jonathan Malessa malessa@inray.de Signed-off-by: Jonathan Malessa <malessa@inray.de>
|
Please wait until #1190 is merged in, as it's going to replace all this code. I also disagree with removing the column from later MySQL versions, just because an unsupported version of MySQL (5.5) doesn't have it. We need to find a better way to test for it at runtime. |
bgrainger
requested changes
Jul 18, 2022
| @@ -49,7 +49,6 @@ public void ColumnsSchema() | |||
| AssertHasColumn("CHARACTER_MAXIMUM_LENGTH", typeof(long)); | |||
| AssertHasColumn("NUMERIC_PRECISION", typeof(ulong)); | |||
| AssertHasColumn("NUMERIC_SCALE", typeof(ulong)); | |||
| AssertHasColumn("DATETIME_PRECISION", typeof(uint)); | |||
There was a problem hiding this comment.
This code exists to verify that changes haven't introduced a regression; you can't just delete it to make the tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1192