Skip to content

Handle case where context has no user identifier #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Handle case where context has no user identifier #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd448af
Handle case where context has no user identifier
Dec 5, 2016
0302588
Don't call show_feature if context key is invalid
Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions feature_flipper/templatetags/feature_flipper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ def render(self, context):
"""
user = self._get_value(self.user_key, context)
feature = self._get_value(self.feature, context)
allowed = show_feature(user, feature)

if feature is None:
return ''

allowed = show_feature(user, feature)
return self.nodelist.render(context) if allowed else ''

def _get_value(self, key, context):
Expand All @@ -57,4 +60,4 @@ def _get_value(self, key, context):
return key[1:-1]
if key in string.digits:
return int(key)
return context[key]
return context.get(key, None)
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
author_email='scott.walton@mypebble.co.uk',
description='A simple, customisable, feature flipper',
url='https://github.com/mypebble/django-feature-flipper.git',
version='0.0.7',
version='0.0.8',
packages=find_packages(),
license='MIT',
long_description=LONG_DESCRIPTION,
Expand Down