Handle case where context has no user identifier #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-w
suggested changes
Dec 5, 2016
| if key in string.digits: | ||
| return int(key) | ||
| return context[key] | ||
| return context.get(key, False) |
There was a problem hiding this comment.
This is depending on the fact that False is 0 in Python 2 (which doesn't hold for Python 3). You'd be best changing this round a bit so there's a concept of there being no value at all here, then passing that information to the render method somehow.
If _get_value hasn't got a valid key then it shouldn't call show_feature at all.
scott-w
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops
feature-flipperfrom throwing aKeyErrorexception when the template tag's "user identifier" argument isn't contained in the page context