Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes asyml#499 (comment)
Description of changes
Configurable
and relevant changes from Forte master branchConfigurable
and adapts new__init__
signature.NameMatchSelector
andRegexNameMatchSelector
are backward compatiblePossible influences of this PR.
For backward compatibility, the
__init__
ofNameMatchSelector
andRegexNameMatchSelector
are now more generic, taking arguments*args
and**kwargs
. Not sure whether this will cause some problems.Test Conducted
In
tests/forte/data/selector_test.py
, addedtest_name_match_selector_backward_compatability
andtest_regex_name_match_selector_backward_compatability
to test backward compatibility of these two selectos.