Skip to content

Selector serialization #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2021
Merged

Selector serialization #1

merged 7 commits into from
Sep 9, 2021

Conversation

zhanyuanucb
Copy link

This PR fixes asyml#499 (comment)

Description of changes

  • Included Configurable and relevant changes from Forte master branch
  • Selector inherits from Configurable and adapts new __init__ signature.
  • Assured NameMatchSelector and RegexNameMatchSelector are backward compatible
  • Slightly changed in Forte pipeline deserialization to instantiate a selector from configs

Possible influences of this PR.

For backward compatibility, the __init__ of NameMatchSelector and RegexNameMatchSelector are now more generic, taking arguments *args and **kwargs. Not sure whether this will cause some problems.

Test Conducted

In tests/forte/data/selector_test.py, added test_name_match_selector_backward_compatability and test_regex_name_match_selector_backward_compatability to test backward compatibility of these two selectos.

@mylibrar mylibrar merged commit 6c8a1c5 into mylibrar:suqi-localtest Sep 9, 2021
@zhanyuanucb zhanyuanucb deleted the selector_serialization branch September 9, 2021 23:48
@zhanyuanucb zhanyuanucb restored the selector_serialization branch September 14, 2021 01:04
@zhanyuanucb zhanyuanucb deleted the selector_serialization branch September 14, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants