-
Notifications
You must be signed in to change notification settings - Fork 60
Add pipeline states to ir #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 79.22% 79.35% +0.13%
==========================================
Files 220 220
Lines 15574 15718 +144
==========================================
+ Hits 12338 12473 +135
- Misses 3236 3245 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. There are a few comments to fix.
But for the problem on selector serialization, we may need to have a better solution. The selectors
are currently very flexible but hard to serialize, an alternative is to restrict its interface (for example, use HParam/Config and remove all init kwargs). This may require another PR. Let's fix the rest of the comments and keep this PR on hold.
Probably also see if we can fix the pipeline format here? |
Blocked by #503 |
…tor_serialization
Selector serialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these all look good now.
This PR fixes #498 .
Description of changes
"selector"
key indefault_configs()
."PIPELINE_STATES"
in IR to serialized the current state of pipeline._initialized
_enable_profiling
_check_type_consistency
_do_init_type_check
resource.onto_specs_dict
resource.merged_entry_tree
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
remote_processor_test.py
is updated to check whether a pipeline can correctly update its states based on IR.