Skip to content

Preserve prerelease case when matching release assets #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxcl merged 1 commit into from
Oct 7, 2026
Merged

Preserve prerelease case when matching release assets #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions AppUpdater.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,8 +762,7 @@ struct Release: Decodable, Comparable {
let prefix = "\(repo.lowercased())-"
return assets.first { asset in
let name = (asset.name as NSString).deletingPathExtension
.lowercased()
guard asset.contentType == .dmg, name.hasPrefix(prefix) else {
guard asset.contentType == .dmg, name.lowercased().hasPrefix(prefix) else {
return false
}
return Version(tolerant: name.dropFirst(prefix.count)) == tagName
Expand Down
12 changes: 12 additions & 0 deletions Tests/AppUpdaterTests/AppUpdaterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,18 @@ final class AppUpdaterTests: XCTestCase {
}
}

func testViableAssetPreservesPrereleaseCase() throws {
let matching = try release(
"v2.0.0-RC.1", prerelease: true, assetName: "APPUPDATER-2.0.0-RC.1.dmg"
)
XCTAssertEqual(matching.viableAsset(forRepo: "AppUpdater")?.name, "APPUPDATER-2.0.0-RC.1.dmg")

let mismatched = try release(
"v2.0.0-rc.1", prerelease: true, assetName: "AppUpdater-2.0.0-RC.1.dmg"
)
XCTAssertNil(mismatched.viableAsset(forRepo: "AppUpdater"))
}

@MainActor
func testCheckMatchesAssetNamedWithShortVersion() async throws {
let releases = try [
Expand Down
Loading