Repository navigation
Preserve prerelease case when matching release assets - #29
Merged
Merged
Conversation
Coverage Report for CI Build 37630297537Coverage decreased (-0.01%) to 70.876%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mxcl
force-pushed
the
preserve-asset-prerelease-case
branch
from
October 7, 2026 13:39
b95f5f1 to
3526af2
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the stated requirements and includes focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Preserves prerelease casing during asset matching while incorporating #28’s tolerant short-version matching.
Changes:
- Parses asset versions without lowercasing prerelease identifiers.
- Keeps repository-prefix matching case-insensitive.
- Adds regression tests and documents short-version asset names.
| File | Description |
|---|---|
AppUpdater.swift |
Parses and compares asset versions correctly. |
Tests/AppUpdaterTests/AppUpdaterTests.swift |
Covers casing and short-version matching. |
README.md |
Documents accepted asset version formats. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset matching lowercased prerelease identifiers, silently skipping a matching
v2.0.0-RC.1release and accepting anRC.1asset for a distinctrc.1tag. Preserve the version's casing while keeping repository-prefix matching case-insensitive.Addresses #28 (comment).
Validation: the regression test fails on the parent commit for both matching and mismatched prerelease casing. All 84 tests pass with the fix (
swift test --scratch-path /tmp/appupdater-pr28-case-build).