Fix compilation and linking issues #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@aphecetche |
Owner
|
@aphecetche : finally, I modified and it should work now (with int) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mwinn2 please see in this PR a couple of fixes.
The linking problem you had is due to the missing Root dictionary : you have to ask for one using the o2_target_root_dictionary CMake (custom) function
then by removing the dependency of Digit to TimeStamp you also removed the operator== (that came from TimeStamp) for Digit and hence the testDigitMerging was not compiling. So you have to provide an operator== by yourself
While implementing the operator== I came to question (again ?) the timestamp as double. Basically as the Samba is giving us a timestamp as an integer of 20 bits, why can't we simply use timestamp = uint32_t for our Digits ?