-
Notifications
You must be signed in to change notification settings - Fork 488
Digit moved #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digit moved #2634
Conversation
Fix compilation and linking issues
|
Formatting is failing. Can we go on here? |
|
@mwinn2 could you fix the clang-format stuff ? |
|
Seems to be ok now. @aphecetche Can you approve the PR? |
|
Just out of curiosity: is there a reason to move the Digit to {{Detectors/MUON/MCH/Base}} and not to more natural {{DataFormats/Detectors/MUON/MCH}} ? |
|
It probably makes sense to systematically collect these data structures under "DataFormats". |
|
I would prefer we merge this one and move the relevant structures to their "final" destination on a different PR. |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, merging with squashing
WIP: moving digits into Base
@aphecetche : I don't manage to get the linking properly done, sorry, but the easiest is, if you have a look, I think (with my cmake clumsiness it takes otherwise quite some time).