[MU4] Allow ledgerlines exactly as wide as the noteheads #6705
Conversation
|
vtest failures expected |
and fix the vtest bat files to use MuseScore4
Jojo-Schmitz
force-pushed
the
ledgerlinelength-master
branch
from
80a1278 to
40bc83d
Compare
Jojo-Schmitz
changed the title
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| rem create reference | |||
|
|
|||
| set MSCORE=..\msvc.install_x64\bin\musescore.exe | |||
There was a problem hiding this comment.
@igorkorsukov take a look on that
There was a problem hiding this comment.
oops
Was not 100% right before (and apparently hadn't been used since MuseScore3!), and still isn't ;-) But now should work on a 64bit MSVC build.
It is a much simpler script than gen.bat and not meant to be run automatically, and so %INSTALL_PATH% is not set, so I guess we can let this pass for now?
There was a problem hiding this comment.
I think yes, we can pass this (only I would rename to MuseScore4.exe)
This is files not used on CI, as I understand, they for local testing on Windows?
There was a problem hiding this comment.
Yes. And Windows is not case sensitive nor needs the extension when resolving the name of an executable
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| rem create reference | |||
|
|
|||
| set MSCORE=..\msvc.install_x64\bin\musescore.exe | |||
| set MSCORE=..\msvc.install_x64\bin\musescore4.exe | |||
| set DPI=130 | |||
|
|
|||
| %MSCORE% %1.mscz -r %DPI% -o %1.png | |||
There was a problem hiding this comment.
Also here it needs to be %MSCORE% %1.mscx -r %DPI% -o %1.png, mscx vs. mscz, as I just found out.
Still doesn't work though :-(, I can't seem to get MuseScore 4 to run in converter mode.
and fix the vtest bat files to use MuseScore4
Counterpart to #6359