[MU4] Update Bravura to 1.39 #6704
Conversation
|
failing vtests expected |
Jojo-Schmitz
force-pushed
the
bravura-master
branch
from
3add2d5 to
9b74947
Compare
Jojo-Schmitz
changed the title
|
@Jojo-Schmitz I'm not against of this particular update, but we probably need to update the vtests ref-images in this PR? |
|
Maybe. But there's a lot of those that need updating and not just for Bravura as far as I can tell? And many/most of the scores used for that are still from 2.x. I've tried updating the vtests, but can't get MuseScore 4 to run in converter mode (on Windows) :-( |
|
@Jojo-Schmitz Oh, I think it's much easier. In CI_vtests job details you can find an artifact "compare" - https://github.com/musescore/MuseScore/suites/1367961822/artifacts/22385020. It contains the "new" images and the existing "refs". |
|
So just grabbing them from there might be the solution? |
|
Yep, just grab them and upload the new ones here |
|
That would cover only those this PR changes, but not the ones changed by other already merges ones, like from #6705. |
|
No, I think all you need here is to rebase your branch on the latest master (if you didn't it before). So the result would cover all the difference considering the previous PRs. |
Jojo-Schmitz
force-pushed
the
bravura-master
branch
from
9b74947 to
26958b4
Compare
|
Ah! Of course... Well, no, it does not. So I'll add the ledgerlines ones too. |
and match the orginal filenames from Steinberg to ease further updates
by not using `SymId::wiggleArpeggiatoDownArrow` in a `symbolLine()` for an `ArpeggioType::DOWN`, but using the same line as for `ArpeggioType::UP`, just turned upside down.
Jojo-Schmitz
force-pushed
the
bravura-master
branch
from
8c26979 to
407ad2a
Compare
As taken fresh from https://github.com/steinbergmedia/bravura
Follow up to #4879, which updated it to 1.32
Counterpart to #5934 (which is in 3,x meanwhile)