Fix #306750, Fix#306751 - Chord alignment #6219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Works advertised, code looks good to me! vtest failure looks like slight diff not sure why, but perhaps a result of the change to the default? |
njvdberg
force-pushed
the
issue-306750-above-below
branch
2 times, most recently
from
0e0291b to
3c18116
Compare
1 task
|
@njvdberg rebase, please. |
…ween above & below chords and across staves Fix #306751 - Chord symbol alignment changes default position without reason Resolves https://musescore.org/en/node/306750 Resolves https://musescore.org/en/node/306751 Extended the algorithm so it aligns chord symbols, fret diagrams or RNA symbols per staff by collecting the symbols per staff and run the alignment for every staff. When looking for the reference for the alignment, the algorithm now handles placement above and below the staff as two different cases. This solves #306750. Removed an extra offset which was not required anymore but was a left-over of an earlier version of the algorithm. This solves #306751.
njvdberg
force-pushed
the
issue-306750-above-below
branch
from
3c18116 to
9f9d404
Compare
|
@anatoly-os Rebase done. |
|
Is there any progress on the issue discussed on Telgram, where disabling autoplace does not exclude chord symbols from the alignment? This still feels like a necessary change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #306750 - Chord symbol alignment incorrectly forces alignment between above & below chords and across staves
Fix #306751 - Chord symbol alignment changes default position without reason
Resolves https://musescore.org/en/node/306750
Resolves https://musescore.org/en/node/306751
Extended the algorithm so it aligns chord symbols, fret diagrams or RNA symbols per staff by collecting the symbols per staff and run the alignment for every staff. When looking for the reference for the alignment, the algorithm now handles placement above and below the staff as two different cases. This solves #306750.
Removed an extra offset which was not required anymore but was a left-over of an earlier
version of the algorithm. This solves #306751.