Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a decent default for the chord symbol alignment algorithm #6216

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

njvdberg
Copy link
Contributor

Setting a decent default (3.0sp) for the chord symbol alignment algorithm.

PR #6060 introduced an algorithm for aligning chord symbols but for compatibility reasons the default for this algorithm was set to 0.0sp so existing scores are not effected.
However in the discussion in issue 281759 the suggestion was made to change at least the templates in the Jazz category, which will most likely benefit most of the new algorithm, so new scores will start using the aligning be default.
This PR is the implementation of this suggestion.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • [n.a.] I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • [n.a.] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [n.a.] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n.a.] I created the test (mtest, vtest, script test) to verify the changes I made

@MarcSabatella
Copy link
Contributor

See the two bug reports I just filed Regarding the alignment algorithm. Until these are resolved, I would not recommend merging this, but after that I definitely support this.

https://musescore.org/en/node/306750
https://musescore.org/en/node/306751

@njvdberg
Copy link
Contributor Author

Both listed bugs are solved in PR #6219.

@anatoly-os anatoly-os merged commit b3741fc into musescore:3.x Jun 22, 2020
@njvdberg njvdberg deleted the chord-alignment-settings branch July 1, 2020 12:41
anatoly-os pushed a commit that referenced this pull request Jul 23, 2020
Setting a decent default (3.0sp) for the chord symbol alignment algorithm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants